Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Empty" address in subscription #1362

Closed
pebalk opened this issue Jul 13, 2024 · 1 comment
Closed

"Empty" address in subscription #1362

pebalk opened this issue Jul 13, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@pebalk
Copy link

pebalk commented Jul 13, 2024

In the subscription "outbounds": section "address": "" is left empty which cause to fail subscription service:

    "outbounds": [
      {
        "protocol": "shadowsocks",
        "...": "..."
          },

        "settings": {
          "servers": [
            {
              "...": "...",
              "address": "",
              "port": 12345,
              "...": "..."
            }
          ]
        }
      

Instead while checking generated URL and link via Inbounds-Details all is generated correctly using the hostname provided.

It might be the issues with https://github.com/alireza0/x-ui/blob/main/web/assets/js/model/xray.js#L1284 and similar functions as later address is used to generate link instead of host variable:

genSSLink(address='', port=this.port, forceTls, remark='', clientPassword) {
//...
 let link = `ss://${safeBase64(settings.method + ':' + password.join(':'))}@${address}:${port}`;
//...
}
@pebalk pebalk added the bug Something isn't working label Jul 13, 2024
@alireza0
Copy link
Owner

It might be related to your configuration in External Proxy.
genSSLink is a function for generating link and not related to the json Sub!
Link generator is already uses more complex usage of host: https://github.com/alireza0/x-ui/blob/main/web/assets/js/model/xray.js#L1513

@alireza0 alireza0 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants