support for sql tables

[therealadityashankar]

Hey !,
I was wondering if you'd be willing to add support for SQL tables (I'm willing to contribute)

[alisaifee]

Hi @therealadityashankar. I assume you mean using a sql database (postgres/mysql?) to store the rate limit data? I'm open to the idea but would love to hear some more details around your motivation.

[therealadityashankar]

I mostly want to do it because I'm not completely pro the Idea of running a database engine (like sql, mongodb, ...) which is required for large amounts of data and redis parallelly,

The problem is more from a management point of view, also, I kinda don't really wanna set it up, (especially for smaller applications), when I can directly do it with SQL

I'd be using SQLAlchemy, so most SQL dialects should be supported,

I'd have to do some speed testing beforehand though, about how SQL compares to Redis, this article (in the operations section) shows how SQL compares to Redis, (spoiler: SQL is slower) before though to see if its even a good Idea

[alisaifee]

@therealadityashankar I'm going to transfer this issue to the https://github.com/alisaifee/limits repository (since if it were to happen it would be implemented there, not here.

[therealadityashankar]

(sorry if this comes of as rude in advance)

I kinda spent an hour digging through code all the way from https://limits.readthedocs.io/en/latest/custom-storage.html to the source code itself to attempt to write a custom storage implimentation

It'd be amazing in you could better document the code in limits.storage.Storage, as to give an explanation to exactly what each function is supposed to do.

I'm not exactly able to make sense on to how I can actually write my own implimentation

Sorry and Thanks in advance 😸

[alisaifee]

Hi @therealadityashankar. Sorry for the delay in getting back to you on this. Are you still interested in this feature?

[therealadityashankar]

no, not really, I think redis is a better option now compared to sql for this library