Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using app extension only API #69

Closed
igorkulman opened this issue Oct 12, 2018 · 9 comments
Closed

Using app extension only API #69

igorkulman opened this issue Oct 12, 2018 · 9 comments

Comments

@igorkulman
Copy link
Contributor

igorkulman commented Oct 12, 2018

Using the library not only in the "main" app but also in a Share extension, I am getting a warning

inking against a dylib which is not safe for use in application extensions: Carthage/Build/iOS/Reusable.framework/Reusable

The code probably only uses APIs that are "extension-safe", so it would be nice to check the box in the project settings to make the warning disappear.

@igorkulman igorkulman changed the title Using app extension only app Using app extension only API Oct 12, 2018
@AliSoftware
Copy link
Owner

Ah, as I don't use Carthage but Cocoapods I never thought of that; good catch!

Would you be willing to submit a PR? That way as you are one using it with Carthage and app extension I guess you'd be better suited to test it and know the proper changes to make 😉

Thanks!

@marekpridal
Copy link

Strange, I see this warning in last version of Reusable as well 😞

linking against a dylib which is not safe for use in application extensions:
/.../Carthage/Build/iOS/Reusable.framework/Reusable

@igorkulman
Copy link
Contributor Author

You are right. It worked in my fork when I did the PR but still shows the warning here. I must have forgotten to commit something. Will look into it again.

@igorkulman
Copy link
Contributor Author

@marekpridal try github "igorkulman/Reusable" "master", works fine for me in a clean project. If it also works for you, I will create a new PR.

@marekpridal
Copy link

@igorkulman I will test it during weekend, unfortunately I cannot try it sooner 😞

@marekpridal
Copy link

Looks like OK! Thanks a lot! 👍

@AliSoftware
Copy link
Owner

@igorkulman Did you figure out the difference between your fork and my repo? Would love a PR fixing that 😉

@marekpridal
Copy link

marekpridal commented Jan 20, 2019

Yesterday I have changed source in my Cartfile from github "igorkulman/Reusable" "master" to github AliSoftware/Reusable and warning appears again 😞 . I have also tried to clean project and remove derivated data but it doesn't help 😞

:-1: linking against a dylib which is not safe for use in application extensions: /.../Carthage/Build/iOS/Reusable.framework/Reusable

@AliSoftware
Copy link
Owner

Super strange. Is there still a diff between the two that we might have missed?

Also, not sure how Carthage manages its cache, maybe it's using a cached version of my repo and master branch instead of cloning it from the latest master? Would be interesting to check if there's a way to clear Carthage's cache to be sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants