Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package lz4 package #25

Closed
wjo1212 opened this issue Nov 20, 2017 · 2 comments
Closed

package lz4 package #25

wjo1212 opened this issue Nov 20, 2017 · 2 comments

Comments

@wjo1212
Copy link
Collaborator

wjo1212 commented Nov 20, 2017

now, it support lz4, but there's no logservice_lz4 package inside.

@wjo1212
Copy link
Collaborator Author

wjo1212 commented Nov 20, 2017

now, when compress is passed as True, it will use zip instead.
Thus, there's almost no possibility to use lz4 case.
However, LZ4 has a better CPU performance comparing to zip, thus let's keep this issue open and in future allow user to select which compression type to use.

@wjo1212
Copy link
Collaborator Author

wjo1212 commented Feb 2, 2018

zip is enough. don't need it in real case. won't fix.

@wjo1212 wjo1212 added the wontfix label Feb 2, 2018
@wjo1212 wjo1212 closed this as completed Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant