-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement num traits for d128 #21
Comments
It would but it seems like a lot of work. Is there a use case for it? Maybe you want to provide a PR? |
The main use case is usability with other crates, e.g. As for providing a PR, I did plan on looking into it at least a little bit, to see how far I could get before I wasn't able to implement anything on my own. I think I'd mostly just be concerned with the trigonometric functions. I'll try something out in the near future. |
Thanks Eugene! |
Would it be possible to implement the
Float
,Zero
andOne
traits from thenum
crate? I know some other libraries (e.g.nalgebra
) use these as trait requirements for doing calculations, so implementing them ford128
means we can use the struct in other crates that require such traits.Namely, this requires implementing all the trig functions and some extra math ones. I can see
integer_decode
andclassify
being tough to implement, though.The text was updated successfully, but these errors were encountered: