fix: support usernames with multiple dashes #463
Conversation
|
@brandonroberts is attempting to deploy a commit to the All Contributors Team on Vercel. A member of the Team first needs to authorize it. |
gr2m
force-pushed
the
fix-parse-comment-multiple-dashes
branch
2 times, most recently
from
8a84507
to
bcf93a9
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #463 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 451 451
Branches 53 53
=========================================
Hits 451 451
☔ View full report in Codecov by Sentry. |
gr2m
force-pushed
the
fix-parse-comment-multiple-dashes
branch
from
9ec1b4b
to
1f12645
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| "rishi-raj-jain": ['doc'], | ||
| }, | ||
| }) | ||
| }) |
There was a problem hiding this comment.
The test is not failing. Looks like the existing code is working, even without your change?
There was a problem hiding this comment.
here is a test, seems like the username is parsed okay?
There was a problem hiding this comment.
Hmm, that's where I traced it down to parsing the username. It shows a valid username not being parsed here analogjs/analog#362 (comment)
There was a problem hiding this comment.
hm okay I'll do some more testing
There was a problem hiding this comment.
okay I was able to reproduce the problem: gr2m/sandbox#252 (comment).
As I said the test is not failing the implementation of your fix though. Could you please have a look? I'll meanwhile deploy your changes to staging and test that
There was a problem hiding this comment.
confirmed your change is working: gr2m/sandbox#252 (comment). So all it's left is to make your test fail before the fix.
There was a problem hiding this comment.
Sure, thanks
gr2m
changed the title
|
@all-contributors add @brandonroberts for code and test |
|
I've put up a pull request to add @brandonroberts! 🎉 |
|
🎉 This PR is included in version 1.19.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
What:
Fixes a bug where a username with multiple dashes is not formatted correctly and the username is not found
Why:
analogjs/analog#362 (comment)
How:
Replaces all occurrences of a dash in the username. Removes all occurrences of the replacement characters
Checklist:
Bot Usage