This repository has been archived by the owner on Apr 21, 2021. It is now read-only.
doc: doc fix #24
Merged
doc: doc fix #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added the missing types and removed the uneeded `npx` call in the `commit` NPM script.
Made some bits more comprehensible and fixed some typos
This was referenced Jan 30, 2019
|
Thanks for spotting these @Berkmann18 |
jakebolam
approved these changes
Jan 30, 2019
|
@allcontributors Please add me for docs. |
|
I've put up a pull request to add @me! 🎉 |
|
@all-contributors Please add Berkmann18 for docs. |
|
I've put up a pull request to add @Berkmann18! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was translating some files to French and checking some of the source strings, I noticed some typos and some bits which missed words or didn't seem to convey the intended meaning (namely the one with "feasible" when it was meant to be the negation of it).
There's still room for improvement but that's up for a discussion.