Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nanna to main #1093

Merged
merged 940 commits into from
Oct 17, 2022
Merged

Nanna to main #1093

merged 940 commits into from
Oct 17, 2022

Conversation

AlvaroHG
Copy link
Collaborator

💣

winthos and others added 28 commits September 27, 2022 16:48
whitespace change to trigger build
Prep for Light Manager (and other updates)
New distance functions and improvements to bbox / magnet sphere code.
fix to incorrectly tagged lightray mesh causing it to show up and block visibility when in instance segmentation mode. This fixes issue #1089
Addresses some inconsistencies noticed via issue #1088, where some receptacle trigger boxes were overlapping oddly with some objects.
I thought we removed this alreadyyyyyyyyyyy
fixes merge conflicts between nanna and main
@lgtm-com
Copy link

lgtm-com bot commented Oct 14, 2022

This pull request introduces 152 alerts and fixes 19 when merging fdb56f1 into d2b2b54 - view on LGTM.com

new alerts:

  • 50 for Use of default ToString()
  • 42 for Useless assignment to local variable
  • 31 for Dereferenced variable may be null
  • 14 for Module is imported more than once
  • 7 for Unused local variable
  • 3 for Module is imported with 'import' and 'import from'
  • 2 for Variable defined multiple times
  • 2 for Container contents are never accessed
  • 1 for Dereferenced variable is always null

fixed alerts:

  • 9 for Dereferenced variable may be null
  • 8 for Use of default ToString()
  • 2 for Useless assignment to local variable

@winthos winthos merged commit e129a2b into main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants