PHPCS for Datepicker and Checkboxes templates #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: - Generic.Files.EndFileNewline.NotFound - Squiz.Commenting.FileComment.Missing - Squiz.ControlStructures.ControlSignature.SpaceAfterCloseParenthesis - WordPress.WhiteSpace.ControlStructureSpacing.NoSpaceBetweenStructureColon - WordPress.WhiteSpace.OperatorSpacing.NoSpaceAfter - WordPress.XSS.EscapeOutput.OutputNotEscaped
Corrects double-escaping of the ID attribute and adds escaping to the 'checked' attribute. Fixes: - Generic.Files.EndFileNewline.NotFound - Squiz.Commenting.FileComment.Missing - Squiz.Strings.DoubleQuoteUsage.NotRequired - WordPress.XSS.EscapeOutput.OutputNotEscaped
| <?php echo $this->get_element_attributes(); ?> | ||
| <?php echo $this->option_selected( $data_row['value'], $value, "checked" ); ?> | ||
| <?php echo $this->get_element_attributes(); // Escaped interally. xss ok. ?> | ||
| <?php echo esc_attr( $this->option_selected( $data_row['value'], $value, 'checked' ) ); ?> |
There was a problem hiding this comment.
i think this would output like, checked="checked", right?
There was a problem hiding this comment.
While I admit I didn't consider that possibility, as far as I can tell this returns just checked, not checked="checked".
|
One concern (which if accurate, seems to reflect a missing unit test heh), otherwise yayyy ☑️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #271.