Fix recursion issue with show_menu and newmenus #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the new function should use |
Arkshine
force-pushed
the
fix/closing-newmenus
branch
4 times, most recently
from
1cda687
to
78dfdff
Compare
Arkshine
force-pushed
the
fix/closing-newmenus
branch
from
78dfdff
to
e634e51
Compare
|
🚢 |
Arkshine
added a commit
that referenced
this pull request
Jan 16, 2016
Fix recursion issue with show_menu and newmenus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by Depresie here: https://forums.alliedmods.net/showthread.php?t=277625.
Side-effect of #140 bugfix. Now that
show_menucloses previous newmenu, it doesn't consider that calling callback could display another newmenus. This patch applies the same infinite loop protection thanmenu_display.