Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Protocol support in gwsocket #16

Open
AurelienMarchand opened this issue Oct 5, 2018 · 4 comments
Open

add Protocol support in gwsocket #16

AurelienMarchand opened this issue Oct 5, 2018 · 4 comments

Comments

@AurelienMarchand
Copy link

AurelienMarchand commented Oct 5, 2018

Websockets offer the option to specify a protocol at connection, yet currently gwsocket drops it silently.
This is to request the feature of tracking the protocol specified at connection so that in strict mode packets can be isolated depending on protocol.

@frink
Copy link

frink commented Oct 2, 2019

@AurelienMarchand - not clear on how this would work.

Could you give a practical example of what you mean?

@AurelienMarchand
Copy link
Author

AurelienMarchand commented Oct 2, 2019

There is no way to tell whether a packet coming in from a browser concerns some code for an internal library or an established sip subprotocol for instance. And I cannot run 2 instances of gwsocket (one for a custom lib and one for the sip subprotocol) since the pipes are hardcoded.

If it was possible to specify the pipes for reading/writing or even better, have the pipe names related to the subprotocol requested, it would be easy to support multi-subprotocols on the same port.

@frink
Copy link

frink commented Oct 13, 2019

So the issue is really about subprotocols in websockets? You want to handle multiple subprotocols from the same websocket URI?

@AurelienMarchand
Copy link
Author

AurelienMarchand commented Oct 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants