Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Theming #3

Open
allo- opened this issue Mar 12, 2016 · 3 comments
Open

Simplify Theming #3

allo- opened this issue Mar 12, 2016 · 3 comments

Comments

@allo-
Copy link
Owner

allo- commented Mar 12, 2016

Create a good HTML template and delegate all theming to CSS files.

@allo-
Copy link
Owner Author

allo- commented Jun 2, 2016

@allo- allo- mentioned this issue Jun 15, 2016
@allo-
Copy link
Owner Author

allo- commented Aug 2, 2016

[ ] Theming via a path to a CSS-File in a config.
[ ] Full themes via additional packages with templates overriding HTML files using the TEMPLATE_DIRS search path. They can extend the default theme using django-apptemplates

@allo-
Copy link
Owner Author

allo- commented Aug 7, 2016

CSS themes are reasonable, but there is nothing which would prevent full themes bringing their own base.html and all other needed files. They may be put in the TEMPLATE_DIRS by the admin or installed via pip as feedjack-theme-x package, as long as render("feedjack/{0}/file.html".format(themename)) works.

Still using the formatstring seems a reasonable choice to allow per-site and per-user theme choice.

Maybe the themes will be moved into a ``themes subfolder to have more general html snippets in the main path.

Old themes should be adapted, once the template and url structure is fixed again: https://github.com/allo-/feedjack/issues/18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant