feat(rpc-trace-types): add support for mux tracer #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtificialPB
requested review from
DaniPopes,
Evalir,
gakonst and
prestwich
as code owners
mattsse
requested changes
Mar 6, 2024
Comment on lines
8
to
10
| pub struct MuxConfig { | ||
| #[serde(flatten)] | ||
| pub tracers: HashMap<GethDebugBuiltInTracerType, Option<GethDebugTracerConfig>>, |
There was a problem hiding this comment.
can we also use tuple new type here like MuxFrame
| @@ -240,6 +253,13 @@ impl GethDebugTracerConfig { | |||
| } | |||
| self.from_value() | |||
| } | |||
|
|
|||
mattsse
approved these changes
Mar 6, 2024
mattsse
pushed a commit
to paradigmxyz/revm-inspectors
that referenced
this pull request
Mar 7, 2024
Adds support for `muxTracer`. Depends on changes from alloy-rs/alloy#252 Once both PR's are good to go I'll open a PR also for `reth`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Part of mux tracer implementation, see: paradigmxyz/revm-inspectors#49
Required by this PR: paradigmxyz/revm-inspectors#57
Solution
Add new Geth built-in tracer type:
muxTracer. Allows executing multiple tracers in a single call.PR Checklist