Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(transport): HttpError #882

Merged
merged 1 commit into from
Jun 12, 2024
Merged

feat(transport): HttpError #882

merged 1 commit into from
Jun 12, 2024

Conversation

yash-atreya
Copy link
Contributor

Motivation

Ref #288

Solution

Add HttpError struct with status and body. Add congruent HttpError enum to TransportErrorKind

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@yash-atreya
Copy link
Contributor Author

@prestwich @mattsse splitting this off from the retry layer PR #849. I'll rebase that after this is merged.

prestwich
prestwich approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@prestwich prestwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good :)

@prestwich prestwich merged commit cfb8df7 into main Jun 12, 2024
22 checks passed
@prestwich prestwich deleted the yash/http_error branch June 12, 2024 15:37
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
@yash-atreya
feat(transport): HttpError (alloy-rs#882)
16faa5d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestwich prestwich prestwich approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yash-atreya @prestwich