-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(signers): adds alloy-signer-gcp #94
Conversation
|
||
/// Reference to a GCP KeyRing. | ||
#[derive(Clone, Debug)] | ||
pub struct GcpKeyRingRef { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check my understanding:
- the
GcpKeyRingRef
specifies a keyring by project, location, and name - it is extended with a
key_id
and aversion
to form a full key specifier - that key specifier is passed in the requests
we may want to clean it up with something like this?
struct KeySpecifier { keyring: GcpKeyRingRef, key_id: String, version: u64 }
impl KeySpecifier {
fn to_key_version_ref(&self) -> String {
// current behavior of `GcpKeyRingRef::to_key_version_ref`
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, that matches my understanding- eventually all these parameters are just used to construct a single string so have implemented KeySpecifier(String)
since the inputs are never used individually
@DaniPopes whenever you have time let's try to get this over the line! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
FYI I've edited the description to use GitHub keywords when referencing issues.
Motivation
Closes #71
Solution
upstreams https://github.com/georgewhewell/ethers-gcp-kms-signer
PR Checklist