feat: unify json-abi params impls #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
force-pushed
the
dani/json-params
branch
from
3ae3a76
to
136298b
Compare
|
Yes. It is good |
prestwich
approved these changes
Jun 22, 2023
|
I still have to think about it, I'll open an issue and merge this for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Having an intermediary untagged enum increases both complexity and runtime overhead (~10% on the seaport bench).
This PR also lays the groundwork for a possible future "borrowed"
JsonAbiimplementation, where all possible types are marked as#[serde(borrow)](either they areCows<'a, _>or&'_ str) and is used for the base serde impls (the owned will just convert from and into this type).@prestwich wdyt
Solution
PR Checklist