Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dyn-abi): fixed arrays coerce_str #442

Merged
merged 1 commit into from
Dec 1, 2023
Merged

fix(dyn-abi): fixed arrays coerce_str #442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 80 additions & 2 deletions crates/dyn-abi/src/coerce.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ impl<'i> Parser<&'i str, DynSolValue, ContextError> for ValueParser<'_> {
this.with(ty).array().parse_next(input).map(DynSolValue::Array)
}),
DynSolType::FixedArray(ty, len) => self.in_list(']', |this| {
this.with(ty).fixed_array(*len).parse_next(input).map(DynSolValue::Array)
this.with(ty).fixed_array(*len).parse_next(input).map(DynSolValue::FixedArray)
}),
as_tuple!(DynSolType tys) => {
self.in_list(')', |this| this.tuple(tys).parse_next(input).map(DynSolValue::Tuple))
Expand Down Expand Up @@ -307,7 +307,10 @@ fn int<'i>(size: usize) -> impl Parser<&'i str, I256, ContextError> {
let name = "int";
trace(
name,
(int_sign, uint(size)).try_map(|(sign, abs)| {
(int_sign, uint(size)).try_map(move |(sign, abs)| {
if !sign.is_negative() && abs.bit_len() > size - 1 {
return Err(Error::IntOverflow);
}
I256::checked_from_sign_and_abs(sign, abs).ok_or(Error::IntOverflow)
}),
)
Expand Down Expand Up @@ -582,6 +585,37 @@ mod tests {
);
}

#[test]
fn coerce_int_overflow() {
assert_eq!(
DynSolType::Int(8).coerce_str("126").unwrap(),
DynSolValue::Int(I256::try_from(126).unwrap(), 8),
);
assert_eq!(
DynSolType::Int(8).coerce_str("127").unwrap(),
DynSolValue::Int(I256::try_from(127).unwrap(), 8),
);
assert!(DynSolType::Int(8).coerce_str("128").is_err());
assert!(DynSolType::Int(8).coerce_str("129").is_err());
assert_eq!(
DynSolType::Int(16).coerce_str("128").unwrap(),
DynSolValue::Int(I256::try_from(128).unwrap(), 16),
);
assert_eq!(
DynSolType::Int(16).coerce_str("129").unwrap(),
DynSolValue::Int(I256::try_from(129).unwrap(), 16),
);

assert_eq!(
DynSolType::Int(8).coerce_str("-1").unwrap(),
DynSolValue::Int(I256::MINUS_ONE, 8),
);
assert_eq!(
DynSolType::Int(16).coerce_str("-1").unwrap(),
DynSolValue::Int(I256::MINUS_ONE, 16),
);
}

#[test]
fn coerce_uint() {
assert_eq!(
Expand Down Expand Up @@ -628,6 +662,28 @@ mod tests {
);
}

#[test]
fn coerce_uint_overflow() {
assert_eq!(
DynSolType::Uint(8).coerce_str("254").unwrap(),
DynSolValue::Uint(U256::from(254), 8),
);
assert_eq!(
DynSolType::Uint(8).coerce_str("255").unwrap(),
DynSolValue::Uint(U256::from(255), 8),
);
assert!(DynSolType::Uint(8).coerce_str("256").is_err());
assert!(DynSolType::Uint(8).coerce_str("257").is_err());
assert_eq!(
DynSolType::Uint(16).coerce_str("256").unwrap(),
DynSolValue::Uint(U256::from(256), 16),
);
assert_eq!(
DynSolType::Uint(16).coerce_str("257").unwrap(),
DynSolValue::Uint(U256::from(257), 16),
);
}

#[test]
fn coerce_uint_wei() {
assert_eq!(
Expand Down Expand Up @@ -938,6 +994,11 @@ mod tests {
DynSolType::Array(Box::new(DynSolType::Bool)).coerce_str("[]").unwrap(),
DynSolValue::Array(vec![])
);
assert_eq!(
DynSolType::FixedArray(Box::new(DynSolType::Bool), 0).coerce_str("[]").unwrap(),
DynSolValue::FixedArray(vec![]),
);
assert!(DynSolType::FixedArray(Box::new(DynSolType::Bool), 1).coerce_str("[]").is_err());
}

#[test]
Expand Down Expand Up @@ -968,6 +1029,23 @@ mod tests {
);
}

#[test]
fn coerce_bool_fixed_array() {
let ty = DynSolType::FixedArray(Box::new(DynSolType::Bool), 3);
assert!(ty.coerce_str("[]").is_err());
assert!(ty.coerce_str("[true]").is_err());
assert!(ty.coerce_str("[true, false]").is_err());
assert_eq!(
ty.coerce_str("[true, false, true]").unwrap(),
DynSolValue::FixedArray(vec![
DynSolValue::Bool(true),
DynSolValue::Bool(false),
DynSolValue::Bool(true),
])
);
assert!(ty.coerce_str("[true, false, false, true]").is_err());
}

#[test]
fn single_quoted_in_array_must_error() {
assert!(DynSolType::Array(Box::new(DynSolType::Bool))
Expand Down
Loading