feat: Solidity events support #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
* fix: event trait fixes * fix: re-exporting event * refactor: event trait take 2 * refactor: improve topic detokenization * refactor: change events to account for indexed structs not in body * fix: move test to bottom of event
prestwich
reviewed
Jun 9, 2023
prestwich
reviewed
Jun 11, 2023
prestwich
reviewed
Jun 11, 2023
prestwich
reviewed
Jun 11, 2023
prestwich
reviewed
Jun 11, 2023
| /// For more details, see the [Solidity reference][ref]. | ||
| /// | ||
| /// [ref]: https://docs.soliditylang.org/en/latest/abi-spec.html#encoding-of-indexed-event-parameters | ||
| pub trait EventTopic: SolType { |
There was a problem hiding this comment.
will this need to be generated in sol! for all structs?
There was a problem hiding this comment.
Can be done with a blanket impl:
impl<T: SolStruct> EventTopic for T
where
T::Tuple: EventTopic,
{
fn topic_preimage_length(rust: &T) -> usize {
let tuple = rust.to_rust();
T::Tuple::topic_preimage_length(&tuple)
}
}But we're cloning the data to get the inner tuple, so this is not ideal
There was a problem hiding this comment.
But we're cloning the data to get the inner tuple, so this is not ideal
I'm gonna think about this a bit more. what do you think of this:
trait SolType {
type BorrowAbstraction: From<Self::RustType>;
fn encode<T: Into<Self::BorrowAbstraction>>(t: T)
}
pub enum TupleBorrowAbstraction<T, U> {
Owned((T,U)),
Borrowed(&(T, U)),
MembersBorrowed((&T, &U))
}
// From impls here
prestwich
requested changes
Jun 11, 2023
This was referenced Jun 12, 2023
This was referenced Jun 12, 2023
Open
prestwich
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38