Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prestwich/events #87

Merged
merged 6 commits into from
Jun 9, 2023
Merged

Prestwich/events #87

merged 6 commits into from
Jun 9, 2023

Conversation

prestwich
Copy link
Member

@prestwich prestwich commented Jun 9, 2023

Changes the event trait to match solidity's and the EVM's behavior

Based on #83, and should be merged into 83

@prestwich prestwich added bug Something isn't working enhancement New feature or request labels Jun 9, 2023
@prestwich prestwich requested a review from DaniPopes June 9, 2023 06:51
@prestwich prestwich self-assigned this Jun 9, 2023
crates/sol-types/src/types/event.rs Outdated Show resolved Hide resolved
crates/sol-types/src/types/event.rs Outdated Show resolved Hide resolved
crates/sol-types/src/types/event.rs Outdated Show resolved Hide resolved
crates/sol-types/src/types/event.rs Outdated Show resolved Hide resolved
@DaniPopes DaniPopes merged commit 68980f8 into dani/events Jun 9, 2023
@DaniPopes DaniPopes deleted the prestwich/events branch June 9, 2023 20:59
DaniPopes pushed a commit that referenced this pull request Jun 9, 2023
* fix: event trait fixes

* fix: re-exporting event

* refactor: event trait take 2

* refactor: improve topic detokenization

* refactor: change events to account for indexed structs not in body

* fix: move test to bottom of event
DaniPopes added a commit that referenced this pull request Jun 12, 2023
* chore: add tests, format attrs

* feat: parse events

* Prestwich/events (#87)

* fix: event trait fixes

* fix: re-exporting event

* refactor: event trait take 2

* refactor: improve topic detokenization

* refactor: change events to account for indexed structs not in body

* fix: move test to bottom of event

* name

* chore: cleanup

* docs

* assign anon variables names in expansion

* wip

* refactor: implement `SolType` for `{Ui,I}nt<N>` and `FixedBytes<N>` with const-generics

* chore: clippy

* chore: add more trait bounds

* clean up code

* cleanups

* finish EventTopic impls

* fix: impl for empty tuple

* chore: clippy

* rm unsafe

* review

* Type only tuple variants, move is_dynamic methods to Type

* chore: clippy

* docs

---------

Co-authored-by: James Prestwich <james@prestwi.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants