Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better titles for mocha hooks #510

Merged
merged 2 commits into from
Oct 28, 2022
Merged

Better titles for mocha hooks #510

merged 2 commits into from
Oct 28, 2022

Conversation

epszaw
Copy link
Member

@epszaw epszaw commented Oct 28, 2022

Context

Uses title instead of originalTitle for mocha hooks to visually simplify dependency between hooks and specs.
Additionally fixes the problem with hook.error is not a function.

fixes #424

Before

image

After

image

Checklist

@epszaw epszaw added type:bug Something isn't working theme:mocha Mocha related issue labels Oct 28, 2022
@epszaw epszaw requested a review from baev October 28, 2022 11:01
@epszaw epszaw marked this pull request as ready for review October 28, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:mocha Mocha related issue type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allure-Mocha: add test name to beforeEach name
2 participants