-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle connection key being empty to support Google Colaboratory #329
Conversation
Thanks @shadaj! Maybe we could add a test case for it in |
@alexarchambault just added in a unit test! |
Thanks, merging! |
How can I enable Almond in Colab? |
@laughedelic I've been installing it by running this notebook. Then importing a notebook (e.g. from the example repo) seems to work. |
Don't know if @shadaj does it this way. |
Cool! Thanks for sharing! I didn't know that I can import notebooks. |
Working on a blog post coming soon :) |
Looking forward to it! I mentioned Colaboratory in the release notes for |
When running kernels on Google Colaboratory, the
key
value inconnection.json
is empty to indicate that authentication and signature checking should be disabled (noted in the official docs). This PR updatesZeromqSocketImpl
to handle the situation wherekey
is empty by using an empty string as the signature when sending a message and skipping the signature check when receiving a message. With these changes, Almond works perfectly inside Colaboratory.