-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editing/deleteing comments #4
Comments
I've added a "commentPassword" (a uuid) that is included in the update url. The comment commit now includes a key generated a sha1 of the commentPassword. This will allow us to allow updates/deletions only from the original comment author. |
From an email: I'm thinking of allowing comment editing and deletion by the original commenter. To do that I'd need to embed markers around each comment in the post files, so in the markdown they'd look a little like this: {% comment %}BEGIN COMMENT {% endcomment %} Comment by tomHello world It's made more confusing by the two meanings of comments in there (the user's comment on the cost and the code comments used to hide the markers from the output). It also relies on Jekyll syntax since markdown doesn't have a comment syntax. This would be customisable but would be confusing to users I think. What do you think? Is it worth it to support editing and deletion? |
It's no possible to delete comments via the server API (just make a DELETE request to the update url). Not implemented client side yet though. |
Deleting is now supported. I'll open a separate issue for editing. |
Users should be able to edit/delete pending comments. Possibly accepted comments as well (in this case it would create a new pull request).
The text was updated successfully, but these errors were encountered: