Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Power mark fails with extra punctuation attached #282

Open
hftf opened this issue Mar 4, 2024 · 4 comments · Fixed by #286
Open

Power mark fails with extra punctuation attached #282

hftf opened this issue Mar 4, 2024 · 4 comments · Fixed by #286
Assignees
Labels
bug Something isn't working Medium priority Medium priority issues

Comments

@hftf
Copy link
Collaborator

hftf commented Mar 4, 2024

I don't have the packet to actually check my hypothesis since I wasn't reading that round and earlier packets were deleted from the packet-sharing thread throughout the day for some reason, but fairly certain I saw a (*), in the question out of the corner of my eye when we had a problem in which a buzz before that token was only counted for 10 points. Possible culprit line:

const powerMarkerIndex: number = format.powers.findIndex((power) => power.marker === trimmedText);

@alopezlago alopezlago added bug Something isn't working Medium priority Medium priority issues labels Mar 5, 2024
@alopezlago
Copy link
Owner

I think it's a bit earlier on this line.:

const currentPowerMarkerIndex = words.indexOf(powerMarker, powerMarkerIndex);

But we have to fix both spots

@alopezlago alopezlago self-assigned this Mar 5, 2024
@alopezlago
Copy link
Owner

Should be fixed in the next verison.

@alopezlago
Copy link
Owner

This wasn't fixed; the branch with the fix is on hold for now, but I'll try porting this fix to the next improvement.

@hftf
Copy link
Collaborator Author

hftf commented Aug 10, 2024

Reopening — issue still exists when a word is unintentionally attached to the (*), e.g. dub(*) (no space).

Found out that it can actually be resolved ad-hoc by adding an extra comma-separated powermark in the options, e.g. dub(*),(*) and setting the point value to 15,15.

@hftf hftf reopened this Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Medium priority Medium priority issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants