Add support for displaying a banner on the GOV.UK homepage #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fofr
reviewed
Mar 13, 2017
| <div id="homepage-promo-banner"> | ||
| <div class="banner-message"> | ||
| <p><strong>Some Title</strong> On some date something has happened. | ||
| <a href="https://something.gov.uk" rel="external nofollow">More information</a></p> |
There was a problem hiding this comment.
This should include the visuallyhidden part that the global banner has so that extra context is added for accessibility
There was a problem hiding this comment.
Done. Thanks for pointing that out, I'll make sure we have copy for the hidden part
fofr
reviewed
Mar 13, 2017
|
|
||
| def stub_template(hash) | ||
| require 'action_view/testing/resolvers' | ||
| @controller.view_paths.unshift(ActionView::FixtureResolver.new(hash)) |
timblair
approved these changes
Mar 14, 2017
This ensures that we can deploy most of the functionality in advance and switch over the banner content in the final deploy. As we want to be able to deploy just the content, the tests need to support a partial both with and without content. To do this, we override the view path to stub templates replacement. This is borrowed from rspec-rails’ `stub_template` method https://github.com/rspec/rspec-rails/blob/e8054a1cd03044f725030fe8315952 cf3799a395/lib/rspec/rails/example/view_example_group.rb#L86-L88
boffbowsh
force-pushed
the
global-banner
branch
from
0200983
to
c00fe66
Compare
boffbowsh
added a commit
that referenced
this pull request
May 25, 2017
Revert "Merge pull request #1171 from alphagov/global-banner"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to deploy a partial containing copy to be placed below the search bar on the GOV.UK homepage. The example at
app/views/homepage/_promo_banner_example.html.erbshould be copied toapp/views/homepage/_promo_banner.html.erband deployed.app/views/homepage/_promo_banner.html.erbshould be left empty if the banner is not in use.Example:
