Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for displaying a banner on the GOV.UK homepage #1171

Merged
merged 2 commits into from Mar 14, 2017
Merged

Add support for displaying a banner on the GOV.UK homepage #1171

merged 2 commits into from Mar 14, 2017

Commits on Mar 13, 2017

  1. This is a replication of the referendum banner 

    implemented in #936 and #938.
    @timblair @boffbowsh
    timblair authored and boffbowsh committed Mar 13, 2017
    Copy the full SHA
    17fca5d View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2017

  1. Move banner into partial 

    This ensures that we can deploy most of the functionality in advance and switch over the banner content in the final deploy.

As we want to be able to deploy just the content, the tests need to support
a partial both with and without content. To do this, we override the view path to stub templates
replacement. This is borrowed from rspec-rails’ `stub_template` method
https://github.com/rspec/rspec-rails/blob/e8054a1cd03044f725030fe8315952
cf3799a395/lib/rspec/rails/example/view_example_group.rb#L86-L88
    @Rosa-Fox @boffbowsh
    Rosa-Fox authored and boffbowsh committed Mar 14, 2017
    Copy the full SHA
    c00fe66 View commit details
    Browse the repository at this point in the history