Resolve missing .govuk-grid-row for calendar views #2800
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These views were using the .govuk-grid-column-* classes without them being inside a .govuk-grid-row which meant that the column floats weren't cleared. This caused the following page component, the feedback prompt, to share the same layout as the columns. This problem is barely noticeable when Javascript is enabled - with just some minor spacing problems at the footer. However without javascript it caused styling to spill out making the page look broken.
|
This was fixed by the revert in #2801 - which seems to imply that the govuk-grid-row class should be set at a higher level than these views. I'm going to close this now and let @injms know about the problem for when he consider re-applying the change. Thanks for having a look @danacotoran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These views were using the .govuk-grid-column-* classes without them
being inside a .govuk-grid-row which meant that the column floats
weren't cleared.
This caused the following page component, the feedback prompt, to share
the same layout as the columns. This problem is barely noticeable when
Javascript is enabled - with just some minor spacing problems at the
footer. However without javascript it caused styling to spill out making
the page look broken.
Before (without JS)
After (without JS)