Prepare for layout component #2802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-gds
force-pushed
the
swap-gem-layout-reduced
branch
from
8af6fb3
to
09851f1
Compare
injms
reviewed
Jun 7, 2021
injms
reviewed
Jun 7, 2021
chris-gds
force-pushed
the
swap-gem-layout-reduced
branch
from
09851f1
to
0d5a25f
Compare
chris-gds
force-pushed
the
swap-gem-layout-reduced
branch
from
0d5a25f
to
cd291fe
Compare
injms
reviewed
Jun 14, 2021
| @@ -6,7 +6,7 @@ class CalendarController < ApplicationController | |||
|
|
|||
| rescue_from Calendar::CalendarNotFound, with: :simple_404 | |||
|
|
|||
| slimmer_template "core_layout" | |||
| slimmer_template "gem_layout" | |||
There was a problem hiding this comment.
This can be safely removed as it'll inherit from ApplicationController
injms
reviewed
Jun 14, 2021
chris-gds
force-pushed
the
swap-gem-layout-reduced
branch
from
cd291fe
to
f040b13
Compare
injms
approved these changes
Jun 15, 2021
chris-gds
force-pushed
the
swap-gem-layout-reduced
branch
from
f040b13
to
abe1dd8
Compare
|
@injms - updated re the comments, rebased + updated the diff table so it captures the these changes (to ensure it's accurate / most recent) |
chris-gds
force-pushed
the
swap-gem-layout-reduced
branch
2 times, most recently
from
7753dfa
to
ad322cf
Compare
|
Hey @injms I don't have auth - do the honours? |
added 4 commits
June 16, 2021 13:29
Update to remove redundant classes and tags, slight margin adjustment
Changing some templates to use the full-width layout. Change layout & dependancies - Remove redundant feedback element (appeared twice on page) - Example Page: /find-local-council Update to resolve visual differences for frontend swap, changes resolve a border that is around the lookup element Remove borders / padding from swap on: "/foreign-travel-advice" to maintain existing visuals.
to include Design System class
+ add margin to replace spacing between lookup and feedback. eg: /find-local-council
added 6 commits
June 16, 2021 13:29
Adjust grid to match Design System + slight margin adjustments to mimic current design
- Update "/settle-in-the-uk" flow to use Design System grid, - Remove redundant CSS - Adjust Design to maintain or align.
Redundant as gem_layout_full_width replaces this.
Updating pages "/when-do-the-clocks-change" "/bank-holidays" To align to the Design System structure of page layout
Updating frontend to use the gem_layout Remove unused CSS
Remove CSS not in use, adjust margins for images to mimic live
chris-gds
force-pushed
the
swap-gem-layout-reduced
branch
from
ad322cf
to
b73b0fc
Compare
injms
reviewed
Jun 16, 2021
Restore Cookie Settings
chris-gds
force-pushed
the
swap-gem-layout-reduced
branch
from
236d2ac
to
8f43aa8
Compare
This was referenced Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update
frontendapp to usegem_layouttemplate fromstatic.Why?
As part of on-going a11y work to align architecture & use Components. To ensure consistency and future proof to allow a11y improvements to cascade across the site.
Selection of visuals differences
Slight changes, some manual spacing adjustments have been made to mimic current design.
Anything else?
Related PRs
Original PR (merged premature)
Enhancement PR:
Remove duplicate
<headers>Resolve e2e PR
alphagov/govuk_publishing_components#2101
Adding additional URLs to README for ref.
#2793
Related PR on
collectionsThere was an issue highlighted on the
calendars(after initial merge) that's also been updated.#2800
Converting the layout to the gem version resulted in the lookup pattern not inheriting the relevant styling correctly. Upon inspection, this is due to elements from the gem like
fieldsetnot being utilised withinfrontendand therefore not using the shared classes - this has been manually adjusted.Example page:
http://www.gov.uk/find-electoral-things
Solution
This ties into the issue raised here:
alphagov/govuk_publishing_components#2096
Should the lookup pattern be it's own Component or use a common combination of Components (
fieldset, input, buttonetc) these discrepancies would reduce.