Skip to content
This repository has been archived by the owner on Apr 16, 2021. It is now read-only.

Host the favicon.ico 'locally' for improved performance #151

Closed
Nooshu opened this issue Mar 23, 2020 · 0 comments · Fixed by #152
Closed

Host the favicon.ico 'locally' for improved performance #151

Nooshu opened this issue Mar 23, 2020 · 0 comments · Fixed by #152
Assignees
@NickColley

Comments

@Nooshu
Copy link
Contributor

Nooshu commented Mar 23, 2020

At the moment we have a whole new TCP connection created to www.gov.uk, which is then redirecting back to the assets domain. A whole TCP connection for a 301 redirect and a 5KB icon file is a waste. We should look at hosting the icon on the service domain and linking to it in the <head>.

Waterfall:
waterfall

Connection view:
connection-view

WebPageTest results
@Nooshu Nooshu changed the title Host the favicon 'locally' for improved performance Host the favicon.ico 'locally' for improved performance Mar 23, 2020
@NickColley NickColley self-assigned this Mar 23, 2020
NickColley added a commit that referenced this issue Mar 23, 2020
@NickColley
Self host favicon
5dd52f4 
Prevents the need to open a request to another domain.

Closes #151
@NickColley NickColley mentioned this issue Mar 23, 2020
Merged
NickColley added a commit that referenced this issue Mar 23, 2020
@NickColley
Self host favicon
63d6faf 
Prevents the need to open a request to another domain.

Closes #151
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NickColley NickColley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Self host favicon alphagov/govuk-coronavirus-vulnerable-people-form
2 participants
@Nooshu @NickColley