Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CI/CD to GitHub Actions #89

Closed
6 of 9 tasks
36degrees opened this issue Dec 1, 2020 · 0 comments · Fixed by #158
Closed
6 of 9 tasks

Move CI/CD to GitHub Actions #89

36degrees opened this issue Dec 1, 2020 · 0 comments · Fixed by #158
Assignees
Labels
Effort: hours Used by the team when triaging small story

Comments

@36degrees
Copy link
Contributor

36degrees commented Dec 1, 2020

What

Move Frontend Docs' CI/CD from Travis to GitHub Actions.

Why

Travis' changes to our plan means that builds are getting stuck in a queue, which means they can take around 30 minutes to run.

Given that the direction of travel for the organisation seems to be towards GitHub Actions, and to be consistent with the approach we're taking with the Prototype Kit, move to GitHub Actions.

Who needs to know about this

Hanna, Laurence, Eoin

Further detail

Travis currently (as per the config) does two things:

  • Builds the site and runs a link checker
  • On the master branch, if the site builds and link checker passes, deploys the site to PaaS

Equivalent jobs need to be run using GitHub Actions.

There's an example of a workflow that deploys to PaaS from National Lottery Heritage Fund here:
https://github.com/heritagefund/funding-frontend/blob/master/.github/workflows/deploy-to-production-workflow.yml

We need to make sure that the production site can still be indexed, as the check is currently based on the TRAVIS_BRANCH environment variable.

We should make sure that the secrets are stored at the environment level with branch protection, as per https://github.com/alphagov/design-system-team-internal/issues/446.

Done when

  • Use of secrets signed off with IA
  • Existing open PRs merged / closed where possible to avoid needing to rebase
  • GitHub Actions config added
  • GitHub secrets added at environment level with branch protection
  • Travis config removed
  • noindex meta tag condition updated
  • Required status checks updated
  • Updated CODEOWNERS file
  • Documentation updated:

# Exclude `/vendor` because on Travis other gems get installed there

# Set dynamically in config.rb depending on TRAVIS_BRANCH
# prevent_indexing: false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort: hours Used by the team when triaging small story
Projects
Development

Successfully merging a pull request may close this issue.

4 participants