Skip to content

Commit

Permalink
Remove Percy SDK waitForPercyIdle() workaround
Browse files Browse the repository at this point in the history
We first added the workaround in:
#3767

The Percy issue was fixed in:
percy/cli#1137 (comment)
  • Loading branch information
colinrotherham committed Dec 11, 2023
1 parent 27cf340 commit b65c2d2
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 20 deletions.
8 changes: 0 additions & 8 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions shared/tasks/browser.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import {
} from '@govuk-frontend/lib/components'
import { filterPath } from '@govuk-frontend/lib/files'
import percySnapshot from '@percy/puppeteer'
import { waitForPercyIdle } from '@percy/sdk-utils'
import puppeteer from 'puppeteer'

/**
Expand Down Expand Up @@ -69,9 +68,6 @@ export async function screenshots() {

// Close browser
await browser.close()

// Wait for Percy to finish
return waitForPercyIdle()
}

/**
Expand Down
8 changes: 0 additions & 8 deletions shared/tasks/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,5 @@
"sass-embedded": "^1.69.5",
"slash": "^5.1.0",
"yargs-parser": "^21.1.1"
},
"peerDependencies": {
"@percy/sdk-utils": "^1.26.2"
},
"peerDependenciesMeta": {
"@percy/sdk-utils": {
"optional": true
}
}
}

0 comments on commit b65c2d2

Please sign in to comment.