Wait for Percy to idle before screenshot task finishes #3767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrotherham
added
🐛 bug
colinrotherham
force-pushed
the
percy-idle
branch
from
85f4cc9
to
af509cc
Compare
This attempts to solve a race condition where `percy exec` starts “finalizing” the Percy build early Even after the `percySnapshot()` promise resolves, resource and snapshot uploads are still in progress See: percy/cli#1137 (comment) This commit also uses a tighter `peerDependencies` range to bump the minimum Percy SDK utils version from 1.24.0 to 1.25.0, maybe this will help too
This restores the default 5x concurrent browsers for asset discovery after an attempted fix in: 75d047d
Percy runs healthchecks in each `percySnapshot()` call and might cause a potential race condition
colinrotherham
force-pushed
the
percy-idle
branch
from
af509cc
to
c599ed5
Compare
romaricpascal
approved these changes
Jun 9, 2023
Thanks @romaricpascal Percy issues seem to have settled down again now Maybe their backend services were slow to finish uploads, but hopefully |
colinrotherham
added a commit
that referenced
this pull request
Dec 11, 2023
We first added the workaround in: #3767 The Percy issue was fixed in: percy/cli#1137 (comment)
colinrotherham
added a commit
that referenced
this pull request
Dec 11, 2023
We first added the workaround in: #3767 The Percy issue was fixed in: percy/cli#1137 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a workaround for a potential Percy CLI bug affecting:
percy exec -- npm run test:screenshotsTo avoid a potential race condition (see discussion) I've included:
waitForPercyIdle()from @percy/sdk-utilsConsole output with
percy exec --verbosePercy continues to show lots of unfinished activity for resource and snapshot uploads after the
await percySnapshot()promises have resolved andnpm run test:screenshotsoutputsFinished 'screenshots'I've attached the full log output
percy-exec.logor see the following excerpt: