Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox visual bug with back button #1236

Closed
BNewing opened this issue Mar 5, 2019 · 3 comments
Closed

Firefox visual bug with back button #1236

BNewing opened this issue Mar 5, 2019 · 3 comments

Comments

@BNewing
Copy link

BNewing commented Mar 5, 2019

This is a tiny issue, but on Firefox, the focus state of the back button has a little visual bug. It has a small white line at the top, which breaks the background highlighting:

image

I found this on a project I was working on and the workaround I implemented was to add a border to the element and make it the same colour as the focus state when focused, and transparent when not focused.

@36degrees
Copy link
Contributor

Thanks for raising, Beverley.

Just to let you know that because this relates to the markup of the component itself I'm going to transfer this issue to the govuk-frontend repo and we'll track this there 👍

@36degrees 36degrees transferred this issue from alphagov/govuk-design-system Mar 5, 2019
@kellylee-gds kellylee-gds added awaiting triage Needs triaging by team Effort: days and removed awaiting triage Needs triaging by team Effort: days labels Mar 6, 2019
@dashouse
Copy link

dashouse commented Mar 6, 2019

@BNewing Thanks Beverley, we're in the process of updating the focus style more generally for WCAG 2.1 compliance and the current proposal also fixes this issue.

We'll keep this open so we can refer to it when that work is complete and make sure that is addressed.

@36degrees
Copy link
Contributor

36degrees commented May 20, 2019

Just to confirm that this has been fixed as part of the focus state changes, and will be going out in GOV.UK Frontend 3.0.

Screen Shot 2019-05-20 at 15 20 34

(Screenshot from Firefox 66)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants