Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update footer links to use new focus style #1321

Merged
merged 2 commits into from May 10, 2019

Conversation

@nickcolley
Copy link
Contributor

commented May 8, 2019

V3 focus styles

footer-new-focus-styles

V3 focus styles with legacy mode turned on

footer-new-focus-styles-legacy

Pre-v3 focus styles

footer-old-focus-styles

Closes #1320

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1321 May 8, 2019 Inactive

@nickcolley nickcolley added this to Needs review in Design System Sprint Board via automation May 8, 2019

@nickcolley nickcolley marked this pull request as ready for review May 8, 2019

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1321 May 8, 2019 Inactive

@nickcolley nickcolley added this to the v3.0.0 milestone May 8, 2019

@@ -44,7 +44,12 @@
}

.govuk-footer__link {
@include govuk-focusable-fill;
text-decoration: none;

This comment has been minimized.

Copy link
@36degrees

36degrees May 9, 2019

Contributor

@dashouse are you happy for this change to be made in 'compatibility mode' as well?

This comment has been minimized.

Copy link
@nickcolley

nickcolley May 9, 2019

Author Contributor

Good shout, will see what @dashouse thinks.

@36degrees
Copy link
Contributor

left a comment

Looks good – one minor comment, and want to check that Dave's happy with the text-decoration change being applied in 'compatibility mode'

&:focus {
color: $govuk-focus-text-colour;
}
@include govuk-focusable-text-link;

This comment has been minimized.

Copy link
@36degrees

36degrees May 9, 2019

Contributor

Is the positioning of this important (coming after the pseudo-classes)? If so, might be worth a comment as I think we generally try and do our includes together at the top of the ruleset.

This comment has been minimized.

Copy link
@nickcolley

nickcolley May 9, 2019

Author Contributor

Yeah we tend to put focus styles at the end of the block, I would prefer to have the mixin only contain properties to avoid this confusion.

I've had to do this in a few places to make sure the focus is applied correctly without needing to undo CSS.

It's on my list of things to consider once we've done all the work and know what the mixins need to do...

@dashouse

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

Sorry if this wasn't clear but the links that are inline within a paragraph should have an underline. In this case that would be Government Digital Service and Open Government Licence v3.0

Regarding the legacy mode, should probably keep the underlines if it's not too much trouble.

@nickcolley nickcolley force-pushed the new-footer-focus branch from 51ff5d7 to 8784426 May 10, 2019

@nickcolley nickcolley merged commit 1837fdf into v3 May 10, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

Design System Sprint Board automation moved this from Needs review to Done May 10, 2019

@nickcolley nickcolley deleted the new-footer-focus branch May 10, 2019

@nickcolley

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

Spoke to people on Slack, since people using govuk_template wont be using this component, it seems like it's not a big importance to add the old behaviour.

@dashouse

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

Did you manage to make the inline link change? the preview is dead now

@nickcolley

This comment has been minimized.

Copy link
Contributor Author

commented Jul 12, 2019

Note that this style was updated in this pull request: #1491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.