-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update footer links to use new focus style #1321
Conversation
@@ -44,7 +44,12 @@ | |||
} | |||
|
|||
.govuk-footer__link { | |||
@include govuk-focusable-fill; | |||
text-decoration: none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dashouse are you happy for this change to be made in 'compatibility mode' as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good shout, will see what @dashouse thinks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good – one minor comment, and want to check that Dave's happy with the text-decoration change being applied in 'compatibility mode'
&:focus { | ||
color: $govuk-focus-text-colour; | ||
} | ||
@include govuk-focusable-text-link; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the positioning of this important (coming after the pseudo-classes)? If so, might be worth a comment as I think we generally try and do our includes together at the top of the ruleset.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we tend to put focus styles at the end of the block, I would prefer to have the mixin only contain properties to avoid this confusion.
I've had to do this in a few places to make sure the focus is applied correctly without needing to undo CSS.
It's on my list of things to consider once we've done all the work and know what the mixins need to do...
Sorry if this wasn't clear but the links that are inline within a paragraph should have an underline. In this case that would be Government Digital Service and Open Government Licence v3.0 Regarding the legacy mode, should probably keep the underlines if it's not too much trouble. |
51ff5d7
to
8784426
Compare
Spoke to people on Slack, since people using govuk_template wont be using this component, it seems like it's not a big importance to add the old behaviour. |
Did you manage to make the inline link change? the preview is dead now |
Note that this style was updated in this pull request: #1491 |
Some context on why we removed underlines from @36degrees:
|
Updates based on the changes in: alphagov/govuk-frontend#1321
Updates based on the changes in: alphagov/govuk-frontend#1321
V3 focus styles
V3 focus styles with legacy mode turned on
Pre-v3 focus styles
Closes #1320