Add spellcheck option #1859
Merged
Add spellcheck option #1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1859
vanitabarrett
force-pushed
the
add-spellcheck-option
branch
from
895e1bd
to
6e8f481
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1859
vanitabarrett
force-pushed
the
add-spellcheck-option
branch
from
6e8f481
to
654a4ba
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1859
added 3 commits
July 10, 2020 11:01
The spellcheck attribute can currently be set through the attributes field for the textarea component. This commit makes the spellcheck option more explicit and means it can be set directly without using the attribute field.
The spellcheck attribute can currently be set through the attributes field for the input component. This commit makes the spellcheck option more explicit and means it can be set directly without using the attribute field.
vanitabarrett
force-pushed
the
add-spellcheck-option
branch
from
654a4ba
to
a686f29
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1859
vanitabarrett
force-pushed
the
add-spellcheck-option
branch
from
a686f29
to
5a062f1
Compare
vanitabarrett
pushed a commit
to alphagov/govuk-design-system
that referenced
this pull request
Jul 10, 2020
The spellcheck attribute was added for the input and textarea components in this PR: alphagov/govuk-frontend#1859 This commit updates the associated documentation in the design system to use this new functionality
vanitabarrett
pushed a commit
to alphagov/govuk-design-system
that referenced
this pull request
Jul 10, 2020
The spellcheck attribute was added for the input and textarea components in this PR: alphagov/govuk-frontend#1859 This commit updates all examples in the design system to use this new functionality
vanitabarrett
pushed a commit
to alphagov/govuk-design-system
that referenced
this pull request
Jul 10, 2020
The spellcheck attribute was added for the input and textarea components in this PR: alphagov/govuk-frontend#1859 This commit updates the associated documentation in the design system to use this new functionality
vanitabarrett
pushed a commit
to alphagov/govuk-design-system
that referenced
this pull request
Jul 10, 2020
The spellcheck attribute was added for the input and textarea components in this PR: alphagov/govuk-frontend#1859 This commit updates the associated documentation in the design system to use this new functionality
hannalaakso
approved these changes
Jul 13, 2020
|
nice work! |
vanitabarrett
pushed a commit
that referenced
this pull request
Jul 17, 2020
We added a new spellcheck param to the textarea component in #1859 However, we forgot to add the param to the character count component, which meant it couldn't be passed through to the textarea. This adds the missing param.
vanitabarrett
pushed a commit
that referenced
this pull request
Jul 17, 2020
We added a new spellcheck param to the textarea component in #1859 However, we forgot to add the param to the character count component, which meant it couldn't be passed through to the textarea. This adds the missing param.
vanitabarrett
pushed a commit
that referenced
this pull request
Jul 17, 2020
We added a new spellcheck param to the textarea component in #1859 However, we forgot to add the param to the character count component, which meant it couldn't be passed through to the textarea. This adds the missing param.
vanitabarrett
pushed a commit
that referenced
this pull request
Jul 17, 2020
We added a new spellcheck param to the textarea component in #1859 However, we forgot to add the param to the character count component, which meant it couldn't be passed through to the textarea. This adds the missing param.
vanitabarrett
pushed a commit
that referenced
this pull request
Jul 17, 2020
We added a new spellcheck param to the textarea component in #1859 However, we forgot to add the param to the character count component, which meant it couldn't be passed through to the textarea. This adds the missing param.
vanitabarrett
pushed a commit
that referenced
this pull request
Jul 17, 2020
We added a new spellcheck param to the textarea component in #1859 However, we forgot to add the param to the character count component, which meant it couldn't be passed through to the textarea. This adds the missing param.
Merged
andymantell
added a commit
to surevine/govuk-react-jsx
that referenced
this pull request
Jul 30, 2020
andymantell
added a commit
to andymantell/govuk-frontend-jinja
that referenced
this pull request
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1832
What
Adds a Boolean
spellcheckparam to the input and textarea componentsWhy
Currently, users can add a spellcheck attribute to these components by using the
attributesparam and passing the String value, for example:We want to make the spellcheck attribute more explicit. Making it a Boolean also leaves less room for human error.
Examples: