Add missing spellcheck param to character count #1869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1869
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1869
36degrees
reviewed
Jul 17, 2020
vanitabarrett
force-pushed
the
add-missing-spellcheck-to-char-count
branch
from
2e65fa2
to
28af5e0
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1869
vanitabarrett
force-pushed
the
add-missing-spellcheck-to-char-count
branch
from
28af5e0
to
53e721f
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1869
vanitabarrett
force-pushed
the
add-missing-spellcheck-to-char-count
branch
from
53e721f
to
62d3f94
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1869
|
@36degrees Added tests now - are you ok to re-review please? |
36degrees
suggested changes
Jul 17, 2020
vanitabarrett
force-pushed
the
add-missing-spellcheck-to-char-count
branch
from
62d3f94
to
2ea37d4
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1869
added 2 commits
July 17, 2020 15:39
We added a new spellcheck param to the textarea component in #1859 However, we forgot to add the param to the character count component, which meant it couldn't be passed through to the textarea. This adds the missing param.
vanitabarrett
force-pushed
the
add-missing-spellcheck-to-char-count
branch
from
2ea37d4
to
a12c384
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add missing spellcheck param for the character count component.
Why
We added a new spellcheck param to the textarea component in #1859 However, we forgot to add the param to the character count component, which meant it couldn't be passed through to the textarea.