Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add print styles for the panel component #1947

Merged
merged 2 commits into from
Sep 8, 2020
Merged

Conversation

36degrees
Copy link
Contributor

Because the panel component is currently white text on a green background, it prints without the background with with light grey text (at least in Chrome).

Screenshot 2020-09-07 at 15 40 46

Add print styles to remove the background, set the text colour to black and add a border (like we do when colours are overridden).

Screenshot 2020-09-07 at 15 40 36

Fixes #1946

Because the panel component is currently white text on a green background, it prints without the background with with light grey text (at least in Chrome).

Add print styles to remove the background, set the text colour to black and add a border (like we do when colours are overridden).
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1947 September 7, 2020 14:45 Inactive
Copy link
Member

@christopherthomasdesign christopherthomasdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks completely sensible to me 👍

@CharlotteDowns
Copy link
Contributor

I agree I like it 👍

Copy link
Member

@hannalaakso hannalaakso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@36degrees 36degrees merged commit 9aa0ca2 into master Sep 8, 2020
@36degrees 36degrees deleted the panel-print-styles branch September 8, 2020 07:58
@hannalaakso hannalaakso mentioned this pull request Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define print styles for panel component
5 participants