Ensure accordion uses overriden focus colour #2747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment if you override the focus colour and focus this component this icon will remain yellow. By using the `$govuk-focus-colour` variable we allow this to change as expected.
NickColley
changed the title
NickColley
commented
Aug 4, 2022
| @@ -82,6 +82,7 @@ We’ve also made fixes in the following pull requests: | |||
| - [#2724: Remove redundant `aria-hidden` attribute from the content when using the Details polyfill](https://github.com/alphagov/govuk-frontend/pull/2724) | |||
| - [#2725: Remove padding-right from last column in summary list row](https://github.com/alphagov/govuk-frontend/pull/2725) | |||
| - [#2737: Avoid unnecessary spacing-related media queries](https://github.com/alphagov/govuk-frontend/pull/2737) | |||
| - [#2747: Ensure accordion uses overriden focus colour](https://github.com/alphagov/govuk-frontend/pull/2747) - thanks @NickColley | |||
There was a problem hiding this comment.
me thanking myself 😂
36degrees
approved these changes
Aug 4, 2022
There was a problem hiding this comment.
This change makes sense to me – thanks @NickColley 👍🏻
Just needs a second review from the team and then we can get this merged.
|
This PR is now unexpectedly closed, despite it being a helpful an inoffensive change 🤔 Github hasn't recorded who closed it which isn't super helpful. I'm going to be bold and reopen. @NickColley Did you close this? If you did, did you mean to or was it an accident. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment if you override the focus colour and focus this component this icon will remain yellow.
By using the
$govuk-focus-colourvariable we allow this to change as expected.Before:
After: