Add support for localisation via data-* attributes to Accordion component #2818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2818
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2818
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2818
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2818
querkmachine
changed the title
domoscargin
approved these changes
Sep 1, 2022
36degrees
reviewed
Sep 1, 2022
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2818
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2818
36degrees
approved these changes
Sep 1, 2022
Have translated all strings that are currently possible to translate (should be everything apart from strings in hardcoded JS)
This function and the modified Element.prototype.dataset polyfill are taken from an earlier spike (govuk-frontend PR #2810) Add new helper function to extract config keys by namespace This is used to pull out the i18n-related configuration keys, so that they can be passed into the I18n function. Add data attribute localisation support to Accordion Write unit tests for mergeConfigs and extractConfigByNamespace Amend extractConfigByNamespace to pass unit tests Add Nunjucks parameter documentation Add integration tests for localisation of the accordion Change test -> it Add whitespace control to Yaml values Tweaking whitespace Add data attribute template tests
querkmachine
force-pushed
the
kg-i18n-accordion-attributes
branch
from
b20cef1
to
6ce08cc
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2818
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raising early as a draft PR for visibility and those sweet, sweet automated deployments. Will resolve #2699 on completion.
Element.prototype.datasetpolyfill from the config spike ([SPIKE][DO NOT MERGE] Create IE-compatible configuration merging function #2810).extractConfigByNamespace, which non-destructively filters a flattened configuration object by a given namespace (e.g. retrieving all key-value pairs where the key starts with 'i18n.')