Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for localisation via data-* attributes to Accordion component #2818

Merged
merged 3 commits into from
Sep 1, 2022
Merged

Add support for localisation via data-* attributes to Accordion component #2818

merged 3 commits into from
Sep 1, 2022

Commits on Sep 1, 2022

  1. Add review app example of all translated components 

    Have translated all strings that are currently possible to translate
(should be everything apart from strings in hardcoded JS)
    @querkmachine
    Vanita Barrett-Smith authored and querkmachine committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    8f949e4 View commit details
    Browse the repository at this point in the history

  2. Add ability to customise accordion toggle controls using data attributes 

    This function and the modified Element.prototype.dataset polyfill are taken from an earlier spike (govuk-frontend PR #2810)

Add new helper function to extract config keys by namespace

This is used to pull out the i18n-related configuration keys, so that they can be passed into the I18n function.

Add data attribute localisation support to Accordion

Write unit tests for mergeConfigs and extractConfigByNamespace

Amend extractConfigByNamespace to pass unit tests

Add Nunjucks parameter documentation

Add integration tests for localisation of the accordion

Change test -> it

Add whitespace control to Yaml values

Tweaking whitespace

Add data attribute template tests
    @querkmachine
    querkmachine committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    99d6135 View commit details
    Browse the repository at this point in the history

  3. Add changelog entry

    @querkmachine
    querkmachine committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    6ce08cc View commit details
    Browse the repository at this point in the history