Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Browsersync on http://localhost:3000 #3690

Merged
merged 6 commits into from
May 24, 2023
Merged

Add Browsersync on http://localhost:3000 #3690

merged 6 commits into from
May 24, 2023

Conversation

colinrotherham
Copy link
Contributor

We've seen frequent port :3000 conflicts whilst testing #3491 alongside other services

This PR makes a few changes:

  1. Serving the review app on http://localhost:8080
  2. Proxying review app using Browsersync on http://localhost:3000

Should port :3000 be unavailable we let Browsersync pick a better one

[Browsersync] Proxying: http://localhost:8080
[Browsersync] Access URLs:
 ----------------------------------
       Local: http://localhost:3000
    External: http://10.0.0.35:3000
 ----------------------------------
          UI: http://localhost:3001
 UI External: http://localhost:3001
 ----------------------------------

Avoids conflict with the Design System and other sites on port 3000
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3690 May 24, 2023 14:00 Inactive
package-lock.json Outdated Show resolved Hide resolved
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3690 May 24, 2023 14:41 Inactive
Copy link
Contributor

@domoscargin domoscargin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@colinrotherham colinrotherham merged commit 78247e6 into main May 24, 2023
21 checks passed
@colinrotherham colinrotherham deleted the browser-sync branch May 24, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants