Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Browsersync reload on *.js changes in review app #3691

Merged
merged 1 commit into from
May 24, 2023
Merged

Add Browsersync reload on *.js changes in review app #3691

merged 1 commit into from
May 24, 2023

Conversation

colinrotherham
Copy link
Contributor

@colinrotherham colinrotherham commented May 24, 2023 •
edited
Loading

Adds a missed extension *.js for Browsersync reload from #3690

We'd assumed to watch *.mjs but Rollup outputs *.js by default

@colinrotherham colinrotherham added the 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) label May 24, 2023
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3691 May 24, 2023 15:35 Inactive
domoscargin
domoscargin approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@domoscargin domoscargin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@colinrotherham colinrotherham merged commit 0116919 into main May 24, 2023
20 checks passed
@colinrotherham colinrotherham deleted the browser-sync-extensions branch May 24, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domoscargin domoscargin domoscargin approved these changes

Assignees
No one assigned
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@colinrotherham @domoscargin @govuk-design-system-ci