Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use canvas colour for cookie banner over hardcoded grey #4919

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Use canvas colour for cookie banner over hardcoded grey #4919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98d65b1
Use canvas colour for cookie banner over hardcoded grey
36degrees Apr 3, 2024
5c7ce04
Document in CHANGELOG
36degrees Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ For advice on how to use these release notes see [our guidance on staying up to
We've made fixes to GOV.UK Frontend in the following pull requests:

- [#4906: Update the icon in the warning text component to match the defined text colour and background colour, rather than always being white on black](https://github.com/alphagov/govuk-frontend/pull/4906)
- [#4919: Use canvas colour for cookie banner over hardcoded grey](https://github.com/alphagov/govuk-frontend/pull/4919)

## GOV.UK Frontend v5.3.0 (Feature release)

Expand Down
2 changes: 1 addition & 1 deletion packages/govuk-frontend/src/govuk/components/cookie-banner/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
// when user changes colours in their browser.
border-bottom: $border-bottom-width solid transparent;

background-color: govuk-colour("light-grey");
background-color: $govuk-canvas-background-colour;
}

// Support older browsers which don't hide elements with the `hidden` attribute
Expand Down