Update page template tests to use jsdom #5062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The next commit will refactor the tests to make use of jsdom which requires us to update the filename so that we get the jsdom test environment. Doing this in two commits so that git shows the changes to the file rather than treating it as an addition and a deletion.
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for 6523197 |
romaricpascal
approved these changes
Jun 11, 2024
Comment on lines
+11
to
+13
| document.open() | ||
| document.write(contents) | ||
| document.close() |
There was a problem hiding this comment.
Nice one for replacing the whole document content 🙌🏻
There was a problem hiding this comment.
The tests didn't work otherwise as anything that was meant to be in the <head> ended up in the <body>!
| @@ -357,7 +357,7 @@ describe('Template', () => { | |||
| .digest('base64') | |||
|
|
|||
| // A change to the inline script would be a breaking change, and it would also require | |||
| // updating the hash published in https://frontend.design-system.service.gov.uk/importing-css-assets-and-javascript/#if-your-javascript-isn-t-working-properly | |||
| // updating the hash published in https://frontend.design-system.service.gov.uk/import-javascript/#use-a-hash-to-unblock-inline-javascript | |||
domoscargin
pushed a commit
that referenced
this pull request
Jun 19, 2024
Update page template tests to use jsdom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5010.