Improve Bootstrap 3 styles in IE7 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fofr
commented
Jul 3, 2014
fofr
commented
- Sign on and Travel Advice Publisher have a not insignificant number of IE7 users. Bootstrap 3 doesn't support IE7 by default
- Add a conditional stylesheet that includes many common IE7 resets
- Linearise Bootstrap 3 grid, IE7 doesn't support box sizing
- Include an IE7 class hook for app specific style fixes
- Tweak breadcrumb, tabs and input styles to work better in IE7
* Fix IE7 as best we can, based on https://github.com/coliff/bootstrap-ie7 * Add comments to explain fixes * Linearises grid * Fixes glyphicon font * Fixes small layout issues mostly by applying hasLayout
* Clear nav tab container * Remove breadcrumb indent and render crumbs inline
* Include common CSS resets for peculiar IE7 behaviour, as pulled from version 1 of normalise: https://github.com/necolas/normalize.css/blob/v1/normalize.css * Reduce Bootstrap 3 button height to stay consistent
|
How Travel Advice Publisher looks on IE7: How Travel Advice Publisher will look after it inherits these styles: |
bishboria
added a commit
that referenced
this pull request
Jul 3, 2014
Improve Bootstrap 3 styles in IE7
fofr
added a commit
to alphagov/travel-advice-publisher
that referenced
this pull request
Jul 4, 2014
Upgrade includes: * Improve Bootstrap 3 rendering in IE7 (alphagov/govuk_admin_template#29) * Add helper classes for input widths * Fix rendering of an empty navbar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.