Skip to content
This repository has been archived by the owner. It is now read-only.

Improve Bootstrap 3 styles in IE7 #29

Merged
merged 5 commits into from Jul 3, 2014
Merged

Improve Bootstrap 3 styles in IE7 #29

merged 5 commits into from Jul 3, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jul 3, 2014

  • Sign on and Travel Advice Publisher have a not insignificant number of IE7 users. Bootstrap 3 doesn't support IE7 by default
  • Add a conditional stylesheet that includes many common IE7 resets
  • Linearise Bootstrap 3 grid, IE7 doesn't support box sizing
  • Include an IE7 class hook for app specific style fixes
  • Tweak breadcrumb, tabs and input styles to work better in IE7
fofr added 5 commits Jul 3, 2014
* Fix IE7 as best we can, based on
https://github.com/coliff/bootstrap-ie7
  * Add comments to explain fixes
* Linearises grid
* Fixes glyphicon font
* Fixes small layout issues mostly by applying hasLayout
* Clear nav tab container
* Remove breadcrumb indent and render crumbs inline
* Include common CSS resets for peculiar IE7 behaviour, as pulled from
version 1 of normalise:
https://github.com/necolas/normalize.css/blob/v1/normalize.css
* Reduce Bootstrap 3 button height to stay consistent
@fofr
Copy link
Contributor Author

@fofr fofr commented Jul 3, 2014

How Travel Advice Publisher looks on IE7:
screen shot 2014-07-03 at 13 10 07

How Travel Advice Publisher will look after it inherits these styles:
screen shot 2014-07-03 at 13 07 34

bishboria added a commit that referenced this pull request Jul 3, 2014
Improve Bootstrap 3 styles in IE7
@bishboria bishboria merged commit 94d58e8 into master Jul 3, 2014
1 check passed
1 check passed
default "Build #39 succeeded on Jenkins"
Details
@bishboria bishboria deleted the ie7-shim branch Jul 3, 2014
fofr added a commit to alphagov/travel-advice-publisher that referenced this pull request Jul 4, 2014
Upgrade includes:
* Improve Bootstrap 3 rendering in IE7
(alphagov/govuk_admin_template#29)
* Add helper classes for input widths
* Fix rendering of an empty navbar
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.