Fix text overflow bug in Firefox #1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-ju
previously approved these changes
Nov 4, 2020
andysellick
force-pushed
the
footer-component-tweak
branch
from
db9a775
to
4fa82d4
Compare
|
|
andysellick
force-pushed
the
footer-component-tweak
branch
2 times, most recently
from
630bc53
to
dcb01ed
Compare
|
After almost completely forgetting about this PR, I've applied a far less complex fix. I've tested it in a ton of browsers and it seems to have solved the problem properly this time, but happy for further discussion. |
andysellick
force-pushed
the
footer-component-tweak
branch
from
dcb01ed
to
91d1f77
Compare
danacotoran
approved these changes
Jan 14, 2021
There was a problem hiding this comment.
This is a simple solution and it fixes the issue 💯
The only thing I think I should note is that changing the list items' display property to inline-block does slightly affect the overall spacing on the footer.
Screen.Recording.2021-01-14.at.15.05.35.mov
I don't think it's a significant enough issue to hold this back so I'm happy to approve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix a layout bug in Firefox that was causing single column list items to column wrap into the next column. Wasn't occurring in any other browsers, because apparently only Firefox doesn't support the
break-insideproperty, so this is a bit of a workaround, but including it for other browsers just in case.Tested in Firefox, Chrome, Edge, everything back to IE8.
Why
The layout footer component is now being used live, in Accounts 😱
Visual Changes
Before:
After: