Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gem version to 23.12.3 #1868

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Bump gem version to 23.12.3 #1868

merged 1 commit into from
Jan 14, 2021

Conversation

owenatgov
Copy link
Contributor

@owenatgov owenatgov commented Jan 14, 2021

Includes:

  • Fix text overflow bug in Firefox (PR #1764)
  • Tidy component filenames (PR #1848)
  • Add print styling for magna charta component (PR #1867)
  • Add custom aria label option for layout header nav (PR #1865)
  • Change GOVUK Modules scope to document (PR #1869)

@bevanloon bevanloon temporarily deployed to govuk-publis-release-23-olcs3q January 14, 2021 10:38 Inactive
@injms
Copy link
Contributor

injms commented Jan 14, 2021

Can we hold onto this release for the time being? There looks to be a couple of other things that could be added to this in the next couple of days, and that would help avoid numerous releases and having to update all the apps again and again.

@andysellick
Copy link
Contributor

Yes, I'd really like to get #1848 and #1764 in if possible - anyone able to review?

@owenatgov
Copy link
Contributor Author

I'm perfectly fine with this. Let me know when we can put it out. Presumably we'd review if a fix version would still be suitable? Should I close this now just in case?

@injms
Copy link
Contributor

injms commented Jan 14, 2021

I'm perfectly fine with this. Let me know when we can put it out. Presumably we'd review if a fix version would still be suitable? Should I close this now just in case?

Let's keep it open for now with a do not merge label - then if it needs closing later we can do that then?

@owenatgov owenatgov marked this pull request as draft January 14, 2021 11:04
@andysellick
Copy link
Contributor

I've merged #1848

@owenatgov
Copy link
Contributor Author

@andysellick Did you want to wait until #1764 was merged?

@andysellick
Copy link
Contributor

@owenatgov no that's fine, it's not urgent.

@danacotoran
Copy link
Contributor

@owenatgov we've got a few PR's in Unreleased now, do you want to rebase this and do the honours (unless are we waiting for another merge to happen first)?

@owenatgov owenatgov marked this pull request as ready for review January 14, 2021 15:36
@bevanloon bevanloon temporarily deployed to govuk-publis-release-23-olcs3q January 14, 2021 15:36 Inactive
@owenatgov
Copy link
Contributor Author

Ready to roll, just needs an approve and we're good.

@DilwoarH
Copy link
Contributor

DilwoarH commented Jan 14, 2021

@owenatgov - Can we rebase and add this please #1869?

@bevanloon bevanloon temporarily deployed to govuk-publis-release-23-olcs3q January 14, 2021 15:40 Inactive
@owenatgov
Copy link
Contributor Author

@DilwoarH done

Copy link
Contributor

@andysellick andysellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the PR description to include all the changes in this version?

@DilwoarH
Copy link
Contributor

Can we update the PR description to include all the changes in this version?

Done

@owenatgov owenatgov merged commit 0a8fa32 into master Jan 14, 2021
@owenatgov owenatgov deleted the release-23.12.3 branch January 14, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants