Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add print styling for magna charta component #1867

Merged
merged 2 commits into from
Jan 14, 2021

Conversation

owenatgov
Copy link
Contributor

@owenatgov owenatgov commented Jan 14, 2021

What

Adds display: none to print styling for specific elements within the magna charta bar chart component.

Why

To address a bug raised for print styles where bar charts will duplicate data on print due to the chart element and the original table both being visible.

Visual Changes

Before

Screenshot 2021-01-14 at 10 03 22

After

Screenshot 2021-01-14 at 10 01 31

Card

@bevanloon bevanloon temporarily deployed to govuk-publis-print-view-htb3ow January 14, 2021 10:04 Inactive
@owenatgov owenatgov marked this pull request as ready for review January 14, 2021 10:05
@bevanloon bevanloon temporarily deployed to govuk-publis-print-view-htb3ow January 14, 2021 10:05 Inactive
@injms
Copy link
Contributor

injms commented Jan 14, 2021

Whilst the perfect option would be to have printable charts, this is a good improvement - and the perfect shouldn't get in the way of the good getting shipped.

There's a whole issue about print stylesheets in the design system that's worth a read as well.

@owenatgov
Copy link
Contributor Author

@injms That's a good point. I've made a note to look into this as a little objective to see if I can style it to look pretty and also have a go at applying what the user has picked at the point of pressing print eg: if there are 2 charts and the user switches one to table, the print styles produce 1 table and 1 chart. Until then, it's merge time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants