This repository has been archived by the owner on Oct 11, 2018. It is now read-only.
Add support for ordering of tagged organisations and people #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes them easier to use in the specs as well as the features
Both Policy#organisations and Policy#people should return the things ordered according to the order in which they were tagged.
We need the order of selected organisations to be maintained and correctly persisted.
govuk_admin_template defines a highlight class that we need to override for highlighted selectize results
By explicitly ordering select options such that those that have been selected are rendered first and in order of selection, we ensure that they are listed in the correct order between requests.
|
Could you screenshots? |
| When I set the tagged people to "Another Person" and "A Person" | ||
| Then the policy people should appear in the order "Another Person" and "A Person" | ||
|
|
||
|
|
This includes extra options that allow further configuration of the select field behaviour.
tekin
force-pushed
the
fix-tagging-ordering
branch
from
d770356
to
43ade98
Compare
|
👍 code |
tekin
added a commit
that referenced
this pull request
May 14, 2015
Add support for ordering of tagged organisations and people
bishboria
added a commit
to alphagov/publisher
that referenced
this pull request
Jul 15, 2015
The list of tags is not orderable, but is shown during editing in the order that the tags were added. However, when the draft is saved and then re-displayed, the tags appear in alphabetical order. This has caused some confusion in the past amongst editors. Similar solution to: alphagov/policy-publisher#66
bishboria
added a commit
to alphagov/publisher
that referenced
this pull request
Jul 15, 2015
The list of tags is not orderable, but is shown during editing in the order that the tags were added. However, when the draft is saved and then re-displayed, the tags appear in alphabetical order. This has caused some confusion in the past amongst editors. Similar solution to: alphagov/policy-publisher#66
bishboria
added a commit
to alphagov/publisher
that referenced
this pull request
Jul 16, 2015
The list of tags is not orderable, but is shown during editing in the order that the tags were added. However, when the draft is saved and then re-displayed, the tags appear in alphabetical order. This has caused some confusion in the past amongst editors. Similar solution to: alphagov/policy-publisher#66
bishboria
added a commit
to alphagov/publisher
that referenced
this pull request
Jul 16, 2015
The list of tags is not orderable, but is shown during editing in the order that the tags were added. However, when the draft is saved and then re-displayed, the tags appear in alphabetical order. This has caused some confusion in the past amongst editors. Similar solution to: alphagov/policy-publisher#66
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to tag organisations and people to policies with a specific order.
This switches from select2 to selectize for the JS enhancement to the select fields as this has built-in support for both ordered selects and re-ordering.
Trello: https://trello.com/c/e2D56dvT/267-set-order-of-organisations-on-a-given-policy