Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let publishers self serve cross-domain analytics tracking #397

Merged
merged 4 commits into from Jul 15, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jul 15, 2015

Add a "Department analytics profile" field to transaction editions so that publishers can self serve, and migrate existing cross domain analytics (from https://github.com/alphagov/frontend/blob/d940889b5bb779ca72266c03c7458bb296e010af/app/helpers/cross_domain_analytics_helper.rb).

As a government editor, I need to be able to add cross-domain tracking to my service start page, so that I can measure the entire user journey for my service, and measure the success of any promotional efforts for my service.

screen shot 2015-07-15 at 12 12 20

https://trello.com/c/QyHwb1Zu/

Related: alphagov/govuk_content_models#307

@boffbowsh
Copy link
Contributor

@boffbowsh boffbowsh commented Jul 15, 2015

LGTM but I don't know Publisher that well 👍.

boffbowsh added a commit to alphagov/frontend that referenced this pull request Jul 15, 2015
In conjunction with 
alphagov/publisher#397,
this allows publishers to self-serve adding the 
Google Analytics profile that a transaction page 
uses for cross-domain tracking.
@benilovj
Copy link
Contributor

@benilovj benilovj commented Jul 15, 2015

It feels like there ought to be an integration test for this.

@fofr
Copy link
Contributor Author

@fofr fofr commented Jul 15, 2015

@benilovj I've added an integration test for Transaction Editions which was previously missing, and then a separate test for the analytics profile.

fofr added 3 commits Jul 14, 2015
Departments often want to track user journeys from transaction start
pages through to their service. This will allow publishers to self
serve.

alphagov/govuk_content_models#307
https://trello.com/c/QyHwb1Zu/
Migrate existing analytics profiles from frontend to non-archived
transaction editions

* Add profiles from
https://github.com/alphagov/frontend/blob/d940889b5bb779ca72266c03c7458b
b296e010af/app/helpers/cross_domain_analytics_helper.rb
* 1 new from https://trello.com/c/QyHwb1Zu/
@fofr fofr force-pushed the cross-domain-tracking branch from ece0fa7 to 771a91a Jul 15, 2015
@boffbowsh boffbowsh force-pushed the cross-domain-tracking branch from 771a91a to 536b9ce Jul 15, 2015
@boffbowsh boffbowsh force-pushed the cross-domain-tracking branch from 536b9ce to 3fb4ebb Jul 15, 2015
benilovj added a commit that referenced this pull request Jul 15, 2015
Let publishers self serve cross-domain analytics tracking
@benilovj benilovj merged commit 0157fa6 into master Jul 15, 2015
1 check passed
1 check passed
default "Build #756 succeeded on Jenkins"
Details
@benilovj benilovj deleted the cross-domain-tracking branch Jul 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.