Let publishers self serve cross-domain analytics tracking #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM but I don't know Publisher that well 👍. |
boffbowsh
added a commit
to alphagov/frontend
that referenced
this pull request
Jul 15, 2015
In conjunction with alphagov/publisher#397, this allows publishers to self-serve adding the Google Analytics profile that a transaction page uses for cross-domain tracking.
This was referenced Jul 15, 2015
|
It feels like there ought to be an integration test for this. |
|
@benilovj I've added an integration test for Transaction Editions which was previously missing, and then a separate test for the analytics profile. |
Departments often want to track user journeys from transaction start pages through to their service. This will allow publishers to self serve. alphagov/govuk_content_models#307 https://trello.com/c/QyHwb1Zu/
Migrate existing analytics profiles from frontend to non-archived transaction editions * Add profiles from https://github.com/alphagov/frontend/blob/d940889b5bb779ca72266c03c7458b b296e010af/app/helpers/cross_domain_analytics_helper.rb * 1 new from https://trello.com/c/QyHwb1Zu/
fofr
force-pushed
the
cross-domain-tracking
branch
from
ece0fa7
to
771a91a
Compare
boffbowsh
force-pushed
the
cross-domain-tracking
branch
from
771a91a
to
536b9ce
Compare
boffbowsh
force-pushed
the
cross-domain-tracking
branch
from
536b9ce
to
3fb4ebb
Compare
benilovj
added a commit
that referenced
this pull request
Jul 15, 2015
Let publishers self serve cross-domain analytics tracking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a "Department analytics profile" field to transaction editions so that publishers can self serve, and migrate existing cross domain analytics (from https://github.com/alphagov/frontend/blob/d940889b5bb779ca72266c03c7458bb296e010af/app/helpers/cross_domain_analytics_helper.rb).
https://trello.com/c/QyHwb1Zu/
Related: alphagov/govuk_content_models#307