Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Welsh version for check or update your company car tax #826

Merged
merged 3 commits into from
Apr 25, 2018

Conversation

- cyfeiriad yn y DU
- pasbort neu drwydded cerdyn-llun dilys

[Create a GOV.UK Verify account](https://www.signing.service.gov.uk/dechrau )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ben-strange sorry to jump in like this (I'm working on the welsh translation for personal tax account), but the URL has to point to the service which does the redirect to Verify, it's not possible to link directly to Verify, because the session will not exist.

Also the text below this seems to be duplicated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting these things, Jakub. I'll make the changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have made the changes if you'd be able to review for me? Thanks.

Removed duplication and changed verify link based on Jakub's feedback.
- eich rhif Yswiriant Gwladol
- slip cyflog diweddar, P60 neu basbort y DU sy'n ddilys

[Creu cyfrif Porth y llywodraeth.]((https://www.tax.service.gov.uk/paye/company-car/start-government-gateway])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

llywodraeth.]((https:// double opening brackets there

slug: profi-pwy-ydych
options:
- text: Defnyddio Porth y Llywodraeth
url: https://www.tax.service.gov.uk/account
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would personally stick to the convention as per English version or the link for the registration and would go with https://www.tax.service.gov.uk/paye/company-car/start-government-gateway

url: https://www.tax.service.gov.uk/account
hint_text: Bydd gennych Ddynodydd Defnyddiwr (ID) os ydych wedi cofrestru i wneud pethau fel cyflwyno'ch Ffurflen Dreth Hunanasesiad ar-lein.
- text: Defnyddio GOV.UK Verify
url: https://www.tax.service.gov.uk/ida/sa/login
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing as above, I would go with https://www.tax.service.gov.uk/paye/company-car/start-verify to stay consistent and make sure if the internal address changes, HMRC can still handle/redirect our traffic

@jakubmiarka
Copy link
Contributor

@ben-strange Hi Ben, I've added three more comments. Other than that I think it should be fine. I work on Verify so I'm not authorised to approve.

Changes based on Jakub's feedback.
Copy link
Contributor

@leenagupte leenagupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@leenagupte
Copy link
Contributor

@ben-strange We can merge this when your changes are ready to be published.

@leenagupte leenagupte merged commit d5ac2f6 into alphagov:master Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants